Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(browser): improve the parallelisation logic #6856

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Nov 5, 2024

Description

Just experimenting with different methods (this doesn't work yet). Ideally, tinypool should expose a way to do that @AriPerkkio

Related #6834

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit d16306b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6729fb005e8ecf0008eb840b
😎 Deploy Preview https://deploy-preview-6856--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio
Copy link
Member

The support from Tinypool's side is quite complex as Piscina's codebase is not flexible. There's some work done on tinylibs/tinypool#98 but I'm not sure when I'm ready to continue that 😱

@sheremet-va sheremet-va changed the title perf: orchestrate browser pool on demand perf(browser): improve the parallelisation logic Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants