feat: proof generation using local srs transcript file #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented additional functions for proof generation leveraging either local or remote SRS data, offering the choice between using a local SRS transcript file or fetching from a default or specified remote URL. Refactored existing `prove` function to use a new shared utility function `prove_with_srs`, which accepts an SRS strategy object for SRS data handling. Implemented support for loading local SRS data in the introduced `LocalSrs` trait, which reads the necessary SRS data from a given file path, and updated `NetSrs` trait to optionally accept a custom URL. This makes the proof generation process more portable and less reliant on an internet connection. Added serial test annotations to prevent state pollution between tests that access shared resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented additional functions for proof generation, offering the choice between using a local SRS transcript file or fetching from a default or specified remote URL.
Refactored existing prove function to use a new shared function prove_with_srs, which accepts an SRS strategy object for SRS data handling.
Implemented support for loading local SRS data in the introduced LocalSrs trait, which reads the necessary SRS data from a given file path, and updated NetSrs trait to optionally accept a custom URL. This makes the proof generation process more portable and less reliant on an internet connection.
Added serial test annotations to prevent state pollution between tests that access shared resources.