Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency in PlotPosteriorComparison #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wanjam
Copy link

@wanjam wanjam commented Oct 19, 2016

  • FaceAlpha is managed in a different way starting Matlab R2014b
  • This checks the version and uses the appropriate way
  • Also: PlotPosteriorComparison can now take an optional input argument to plot condition-labels instead of numbers.

* FaceAlpha is managed in a different way starting Matlab R2014b
* This checks the version and uses the appropriate way
* PlotPosteriorComparison can now take an optional input argument to plot condition-labels instead of numbers.'
@suchow
Copy link
Member

suchow commented Oct 31, 2016

Hi, thanks for the contribution! I have one question for you:

On lines 15 to 20, you renamed PlotPosteriorComparison to PlotPosteriorComparisonWanja, which I think will break existing code that uses the original name. Any reason for the renaming?

…moryExperiment for newer Matlab versions

* Corrected the name to PlotPosteriorComparison
* ColorWorkingMemoryExperiment was still using RandSample, which is called PsychRandSample in newer versions of Psychtoolbox
* ColorWorkingMemoryExperiment was throwing an error because 'buttons' was not defined
* ColorWorkingMemoryExperiment still used RandStream.setDefaultStream which was renamed to RandStream.setGlobalStream
	* see https://de.mathworks.com/help/matlab/release-notes.html?rntext=RandStream&startrelease=R2010b&endrelease=R2011a&groupby=release&sortby=descending&searchHighlight=RandStream
@wanjam
Copy link
Author

wanjam commented Nov 1, 2016

Hi,

No! That was just a leftover from testing. Sorry for the mess, I pushed a new version.
I also adjusted ColorWorkingMemoryExperiment.m, which should fix #29 .

@wanjam wanjam closed this Nov 1, 2016
@wanjam wanjam reopened this Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants