Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vioserial] Update MSI interrupt limit #1029

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

kostyanf14
Copy link
Member

@YanVugenfirer
Copy link
Collaborator

Just to add some comment - maybe if CI is still not running, even in the commit message: up until now when several ports were used only one MSI interrupt would be used.

@kostyanf14 kostyanf14 marked this pull request as draft January 17, 2024 08:44
@vrozenfe
Copy link
Collaborator

IMHO the driver will not get any benefits from this patch due to the way how the DPC routine is implemented for this driver.
Originally it was designed to work with IRQL interrupt and DPC just goes through the list of the active posts and polls in and out queues. If I'm not mistaken, when the MSI support was added the developer who did it decided to keep the same way of working for the new MSI interrupts mechanism. So it doesn't matter how many MSI the driver claims, it will only increase the potential number or resources that the driver needs, but not improve the way how ISR-DPC chain implemented in this driver.

In any case this patch seems to be absolutely harmless and if you want to merged it then it's fine with me.

Vadim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants