Fix issue #781 #785
Merged
Fix issue #781 #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solving their parent path
jcp19
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
LGTM! I guess the best way to have systematic tests for this would be to introduce UX tests after running Gobra's current test suit. For the former, we would first need to produce a gobra jar and then we would run it against a set of full Gobra commands provided by us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing
Paths.get(filename).getParentfails iffilenameis a relative path in the current folder (and thus does not have any path component besides the filename itself).Please let me know if you have a great idea for a test case as we would need to invoke Gobra relative to a folder containing a Gobra file such that we can provide a path to the Gobra file without any path component.
Fixes #781