Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to use Z3 via API #666

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Add flag to use Z3 via API #666

merged 6 commits into from
Sep 12, 2023

Conversation

Dspil
Copy link
Contributor

@Dspil Dspil commented Jul 28, 2023

Markus noticed a speedup when running silicon with Z3 via API in scion generated files.

@Dspil Dspil requested a review from jcp19 July 28, 2023 11:17
jcp19
jcp19 approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder what happens when the Z3 API cannot be found though. Does it show an ugly exception or an informative error message? Would there be a way to pass a path to the Z3 API from Gobra?

jcp19
jcp19 reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor comments. After addressing them, we can merge it

src/main/scala/viper/gobra/backend/Silicon.scala Show resolved Hide resolved
src/main/scala/viper/gobra/backend/Silicon.scala Outdated Show resolved Hide resolved
src/main/scala/viper/gobra/backend/Silicon.scala Outdated Show resolved Hide resolved
@Dspil Dspil merged commit 21bd69f into master Sep 12, 2023
2 of 3 checks passed
@Dspil Dspil deleted the z3_api_flag branch September 12, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcp19 jcp19 jcp19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dspil @jcp19