Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 166 #167

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Fix issue 166 #167

merged 4 commits into from
Jan 14, 2021

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Jan 14, 2021 •
edited
Loading

Temporary workaround for issue #166 by disabling selective importing, all contents of an imported package appear in the final viper output

@jcp19 jcp19 requested a review from ArquintL January 14, 2021 11:52
ArquintL
ArquintL approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@ArquintL ArquintL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to close the issue? For me it would make more sense to just reference the issue and say that this is a quick workaround such that we do not forget about it later

@jcp19
Copy link
Contributor Author

jcp19 commented Jan 14, 2021

Do you want to close the issue? For me it would make more sense to just reference the issue and say that this is a quick workaround such that we do not forget about it later

Yes, that is indeed better. The issue will remain open

@jcp19 jcp19 merged commit f924ffc into master Jan 14, 2021
@jcp19 jcp19 deleted the fix-issue-166 branch January 14, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArquintL ArquintL ArquintL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcp19 @ArquintL