Dependencies of Run
#234
Merged
Dependencies of Run
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcp19
commented
Oct 31, 2023
jcp19
commented
Oct 31, 2023
verification/dependencies/golang.org/x/net/internal/socket/socket.gobra
Outdated
Show resolved
Hide resolved
Closed
jcp19
commented
Oct 31, 2023
jcp19
commented
Oct 31, 2023
|
We are currently hung-up in the following error: viperproject/gobra#702 |
6 tasks
Dspil
approved these changes
Nov 6, 2023
| @@ -398,38 +394,35 @@ func (cc *connUDPBase) initConnUDP(network string, laddr, raddr *net.UDPAddr, cf | |||
| return nil | |||
| } | |||
|
|
|||
| // @ preserves c.Mem() | |||
| // @ preserves acc(c.Mem(), _) | |||
There was a problem hiding this comment.
A bit of a nitpick but I would change this to requires (and same for similar cases below). I find it a bit confusing since it is not really preserved.
There was a problem hiding this comment.
I was gonna change this, but decided against. If one expands the definition of _, I would argue that it is preserved:
preserves exists p perm :: 0 < p && p < perm(c.Mem()) && acc(c.Mem(), p)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/viperproject/gobra/pull/700/files