Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1-first documentation #1206

Merged
merged 204 commits into from
Dec 4, 2023
Merged

V1-first documentation #1206

merged 204 commits into from
Dec 4, 2023

Conversation

lourot
Copy link
Contributor

@lourot lourot commented Oct 24, 2023 •
edited by brillout
Loading

Long living (merging ETA: 2023-11-30), collaborative branch for making the documentation teach the V1 design (see #578) first.

Feedback and commits welcome at any time. Please avoid force-pushing.

Preview: https://vike-v1-staging.lourot.dev.

@brillout
Copy link
Member

🚀 Neat.

Please avoid force-pushing.

👍 (Now that Vike's code is increasingly collaborative, I'll stop force pushing on non-brillout/* branches.)

@brillout
Copy link
Member

commits welcome

Just made one. Feel free to object to any of my (future) commits.

@redbar0n redbar0n mentioned this pull request Oct 30, 2023
Open
lourot
lourot commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@lourot lourot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything still LGTM so far 🙏

@brillout
Copy link
Member

@AurelienLourot Let me know if 9ef4a1a is ok for you. Feel free to disagree.

@brillout
Copy link
Member

This now LGTM.

@AurelienLourot Let me know if my latest changes are ok with you. I'll then implement the deprecating warning for the current design and release. Let's prepare the release tweets for Monday.

lourot
lourot commented Nov 30, 2023
View reviewed changes
Copy link
Contributor Author

@lourot lourot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@brillout
Copy link
Member

LGTM 🚀

🙏

Let me release the new version and I'll then merge.

@brillout
Copy link
Member

@AurelienLourot Huge thanks for the PR 🙏 it has been a massive help.

@lourot lourot mentioned this pull request Dec 1, 2023
Closed
@afkcodes
Copy link

afkcodes commented Dec 1, 2023

Amazing work by @AurelienLourot thanks a lot, and thanks @brillout for all the hardwork.

@brillout
Copy link
Member

brillout commented Dec 3, 2023

Everything is ready. Let's merge tomorrow at noon before the release tweet.

@brillout brillout merged commit 6aa1341 into main Dec 4, 2023
34 checks passed
@lourot lourot deleted the aurelien/docs/v1 branch December 4, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brillout brillout brillout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lourot @brillout @afkcodes