Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support uWebSocket.js #22

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat: support uWebSocket.js #22

wants to merge 13 commits into from

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Oct 21, 2024

Changes/TODO

Fix #20

Note: Help and reviews are needed

@rtritto rtritto changed the title feat: init uWebSocket.js support feat: support uWebSocket.js Oct 21, 2024
@rtritto
Copy link
Contributor Author

rtritto commented Oct 21, 2024

FYI @nitedani

@rtritto
Copy link
Contributor Author

rtritto commented Oct 22, 2024

https://github.com/vikejs/vike-node/actions/runs/11464915212/job/31902213911?pr=22

Error: 42.542][/test/vike-node/.prod-uws.test.ts][npm run prod][stderr] ✘ [ERROR] No loader is configured for ".node" files: ../../node_modules/.pnpm/uWebSockets.js@https+++codeload.github.com+uNetworking+uWebSockets.js+tar.gz+442087c0a01bf146_ef5o3ypzxljf3ryz2pfwb3ukxu/node_modules/uWebSockets.js/uws_linux_arm_108.node

What should we use to load native Node (.node) modules?

Some alternatives:

There is a vike plugin to do that?

FYI @brillout @nitedani

@rtritto
Copy link
Contributor Author

rtritto commented Oct 23, 2024

https://github.com/vikejs/vike-node/actions/runs/11464915212/job/31902213911?pr=22

Error: 42.542][/test/vike-node/.prod-uws.test.ts][npm run prod][stderr] ✘ [ERROR] No loader is configured for ".node" files: ../../node_modules/.pnpm/uWebSockets.js@https+++codeload.github.com+uNetworking+uWebSockets.js+tar.gz+442087c0a01bf146_ef5o3ypzxljf3ryz2pfwb3ukxu/node_modules/uWebSockets.js/uws_linux_arm_108.node

What should we use to load native Node (.node) modules?

Some alternatives:

There is a vike plugin to do that?

FYI @brillout @nitedani

I fixed using uws-pack that uses dynamic import to import the current Node.js native module.

Now /test/vike-node/.dev-uws.test.ts got timeout: https://github.com/vikejs/vike-node/actions/runs/11485389164/job/31965334594?pr=22

@brillout
Copy link
Member

brillout commented Nov 1, 2024

I'll have a look at this PR after I'm done with my current backlog. ETA soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support to uWebSockets.js
2 participants