-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support uWebSocket.js #22
base: main
Are you sure you want to change the base?
Conversation
FYI @nitedani |
https://github.com/vikejs/vike-node/actions/runs/11464915212/job/31902213911?pr=22 Error: 42.542][/test/vike-node/.prod-uws.test.ts][npm run prod][stderr] ✘ [ERROR] No loader is configured for ".node" files: ../../node_modules/.pnpm/uWebSockets.js@https+++codeload.github.com+uNetworking+uWebSockets.js+tar.gz+442087c0a01bf146_ef5o3ypzxljf3ryz2pfwb3ukxu/node_modules/uWebSockets.js/uws_linux_arm_108.node What should we use to load native Node ( Some alternatives:
There is a vike plugin to do that? |
|
f1e2417
to
9dd6074
Compare
I'll have a look at this PR after I'm done with my current backlog. ETA soon. |
Changes/TODO
cors
middleware (enabled by default) in Vite Dev Server:cors
middleware, used by Vite, uses isn't compatible with responde and request as Request, IncomingMessage, ServerResponse of Node.js; source: https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/index.ts#L831createServerResponse.ts
file (same as https://github.com/vikejs/vike-node/blob/main/packages/vike-node/src/runtime/adapters/createServerResponse.ts) to bind (replace) theres.writeHead
used by Vite middleware https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/middlewares/base.tsFix #20
Note: Help and reviews are needed