Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete transaction information when selecting the description of a previous transaction #346

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

robb4
Copy link

@robb4 robb4 commented Nov 2, 2024

Hi folks! I know this is very out of the blue, but I've been using this app for a while and I would really love to have this feature implemented, as it greatly enhances (at least my) user experience.

Note: this code is something I cobbled together in a couple of hours so it's obviously not something I expect to be merged as is.

Summary

  • Added the option to automatically fill in the transaction information when selecting a transaction description from the autocomplete dropdown.
  • Added a new setting under Transaction Form to control this new behavior

This is basically solution 4 from #119 (I found this issue after I wrote the code 😅)

Expected user flow

  • user clicks the Plus button to open the create new transaction form
  • user fills in the transaction value
  • user writes a few characters in the Description input field
  • when selecting an already existing description from the autocomplete options => the remaining input fields should be filled in with values from the selected transaction

Open questions

  • what should happen when the selected transaction is of a different type? (withdraw / transfer / deposit)
  • what should happen when the selected transaction has multiple splits?
  • what should happen when we're autocompleting inside a split transaction? (I think this MR kinda breaks things in this scenario by overwriting the source account)

Please let me know if this is something you're interested to merge.

Have an awesome day!
Robert.

@victorbalssa victorbalssa self-assigned this Nov 7, 2024
@victorbalssa
Copy link
Owner

I will take a look 👀
Thanks @robb4!

@victorbalssa victorbalssa removed their assignment Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants