-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix camel case errors due to changes in team-monitor-website #57
base: tr/saveUser
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to me. But I just want to re-iterate that if making these camelCase starts throwing errors or warnings, just revert these changes and just turn the corresponding values in the team-monitor-website back to snake case.
@@ -56,23 +56,24 @@ pub async fn process_review(message_data: &Vec<u8>) { | |||
fn get_tasks(message_data: &Vec<u8>) -> Option<Review>{ | |||
match serde_json::from_slice::<Value>(&message_data) { | |||
Ok(data) => { | |||
let repo_provider = data["repository_provider"].to_string().trim_matches('"').to_string(); | |||
let repo_name = data["event_payload"]["repository"]["name"].to_string().trim_matches('"').to_string(); | |||
println!("data == {:?}", &data["eventPayload"]["repository"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to keep the println
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@@ -77,15 +77,17 @@ pub async fn handle_install_bitbucket(installation_code: &str) { | |||
async fn send_setup_info(setup_info: &Vec<SetupInfo>) { | |||
let installation_id = env::var("INSTALL_ID") | |||
.expect("INSTALL_ID must be set"); | |||
println!("install_id = {:?}", &installation_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a part of debugging?
Please check the action items covered in the PR -