typescript draft #397
Closed
typescript draft #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckras
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context: The return type of the
TabularDataBySQL/MQLproto has changed to return both a list of structs, the existing return type, and also a list of bytearrays that represent BSON.I added a required dependency to mongodb so we can use BSON. the BSON library has a
deserialize()function that lets us convert BSON-encoded data (the list of lists of bytes) into a typescript list of dictionaries.now date fields will be returned as
DateobjectsI added date objects to the
datatesting data to ensure we were returningdateobjects and not strings