APP-6639 - DoCommand from control tab for services no longer works (regression) #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
approved these changes
Oct 15, 2024
njooma
approved these changes
Oct 15, 2024
|
Can we bump the TS SDK version in this PR so we can bump in App and RC as well? We've gotten a couple reports of folks running into this and I'd like to avoid a rollback of the most recent bump that caused this. |
|
I'll merge this and create a release asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://viam.atlassian.net/browse/APP-6639
We imported the wrong Generic here.
I have built this and manually imported into app & confirmed that this fixed the issue.