Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-4057 Add Power Sensor Component #142

Merged
merged 9 commits into from
Aug 1, 2023

Conversation

oliviamiller
Copy link
Member

@oliviamiller oliviamiller commented Jul 28, 2023

Adds client side code for power sensor component and unit tests.

Copy link
Contributor

@maximpertsov maximpertsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc update + change to readings return value

src/components/power-sensor/power-sensor.ts Outdated Show resolved Hide resolved
src/components/power-sensor/client.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@maximpertsov maximpertsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good minus linting errors, also left some style suggestions

src/components/power-sensor/client.test.ts Outdated Show resolved Hide resolved
Comment on lines 23 to 24
getVolts: () => 1.5,
getIsAc: () => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. if you agree with my suggestion above - same for the ones below

Suggested change
getVolts: () => 1.5,
getIsAc: () => true,
getVolts: () => testVoltage,
getIsAc: () => testIsAc,

src/components/power-sensor/client.ts Outdated Show resolved Hide resolved
@oliviamiller oliviamiller merged commit b784dc4 into viamrobotics:main Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants