-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-4057 Add Power Sensor Component #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc update + change to readings return value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good minus linting errors, also left some style suggestions
getVolts: () => 1.5, | ||
getIsAc: () => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. if you agree with my suggestion above - same for the ones below
getVolts: () => 1.5, | |
getIsAc: () => true, | |
getVolts: () => testVoltage, | |
getIsAc: () => testIsAc, |
Adds client side code for power sensor component and unit tests.