Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra params to MLModel #783

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add extra params to MLModel #783

merged 1 commit into from
Nov 6, 2024
+36 −12

Conversation

njooma
Copy link
Member

@njooma njooma commented Nov 6, 2024

@njooma njooma requested a review from a team as a code owner November 6, 2024 15:43
etai-shuchatowitz
etai-shuchatowitz approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@etai-shuchatowitz etai-shuchatowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy turnaround on this

jckras
jckras approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@jckras jckras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@njooma njooma merged commit b630e05 into viamrobotics:main Nov 6, 2024
12 checks passed
@njooma njooma deleted the hotfix/mlmodel-extra branch November 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckras jckras jckras approved these changes

@etai-shuchatowitz etai-shuchatowitz etai-shuchatowitz approved these changes

@lia-viam lia-viam Awaiting requested review from lia-viam lia-viam is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njooma @etai-shuchatowitz @jckras