Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of robot #781

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Remove mentions of robot #781

merged 1 commit into from
Nov 6, 2024

Conversation

npentrel
Copy link
Contributor

@npentrel npentrel commented Nov 5, 2024

No description provided.

@npentrel npentrel requested a review from a team as a code owner November 5, 2024 17:28
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_properties
mlmodel metadata
slam get_point_cloud_map

Copy link
Member

@jckras jckras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One question: in vision.py, I noticed the pattern changes to just machine instead of robot=machine. This is inconsistent with other files, so should we prioritize consistency within vision.py itself or across all files?

src/viam/services/vision/vision.py Show resolved Hide resolved
src/viam/services/vision/vision.py Show resolved Hide resolved
@npentrel npentrel merged commit f7b35b8 into main Nov 6, 2024
13 checks passed
@npentrel npentrel deleted the robot-machine branch November 6, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants