Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-2954: Update vision.py #776

Merged
merged 3 commits into from
Oct 31, 2024
Merged

DOCS-2954: Update vision.py #776

merged 3 commits into from
Oct 31, 2024

Conversation

npentrel
Copy link
Contributor

No description provided.

@npentrel npentrel requested a review from a team as a code owner October 30, 2024 11:33
@github-actions GitHub Actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_properties
mlmodel metadata
slam get_point_cloud_map

jckras
jckras approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jckras jckras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment about a possible typo, LGTM!

src/viam/services/vision/vision.py Outdated
my_detector = VisionClient.from_robot(robot, "my_detector")

# capture all from the next image from the camera
# // Get the captured data for a camera
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want the # and // ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - that's a typo

@npentrel npentrel merged commit b204349 into main Oct 31, 2024
11 checks passed
@npentrel npentrel deleted the npentrel-patch-1 branch October 31, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckras jckras jckras approved these changes

@njooma njooma Awaiting requested review from njooma njooma is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npentrel @jckras