RSDK-9146: Change Python TabularDataBySQL/MQL return type to raw BSON #774
+98
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckras
requested review from
stuqdog,
purplenicole730 and
lia-viam
and removed request for
purplenicole730
jckras
changed the title
jckras
changed the title
stuqdog
approved these changes
Oct 31, 2024
njooma
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context: The return type of the
TabularDataBySQL/MQLproto has changed to return both a list of structs, the existing return type, and also a list of bytearrays that represent BSON.pymongoto use theBSONlibraryBSONprovides adecode()function for converting lists of byte sequences into Python dictionaries.Testing:
datetimeobjects instead of strings by running tabular_data_by_mql against real tabular data on viam-dev and printed the decoded data and their types:TABULAR_QUERY_RESPONSEtesting data to include datetime objects, as the Python SDK will receive date fields in this format.