Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arm, base, camera snippets #751

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Fix arm, base, camera snippets #751

merged 6 commits into from
Oct 1, 2024

Conversation

JessamyT
Copy link
Contributor

@JessamyT JessamyT commented Oct 1, 2024

DOCS-2779

@JessamyT JessamyT requested a review from a team as a code owner October 1, 2024 01:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_properties
mlmodel metadata
slam get_point_cloud_map

npentrel
npentrel approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

purplenicole730
purplenicole730 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and after Naomi's comments get resolved, LGTM

src/viam/components/camera/camera.py Outdated Show resolved Hide resolved
stuqdog
stuqdog reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo other folks' comments re: image_list and whitespace fixes.

@JessamyT JessamyT merged commit 7c7f37c into viamrobotics:main Oct 1, 2024
12 checks passed
@JessamyT JessamyT deleted the arm-QA branch October 1, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplenicole730 purplenicole730 purplenicole730 approved these changes

@stuqdog stuqdog stuqdog left review comments

@npentrel npentrel npentrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JessamyT @npentrel @stuqdog @purplenicole730