Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-7747: Add SetRPM to python SDK #627

Merged
merged 4 commits into from
May 31, 2024

Conversation

martha-johnston
Copy link
Contributor

actual changes are in the first commit, second is autogenerated files

will merge API changes that this depends on later today

@martha-johnston martha-johnston requested a review from a team as a code owner May 29, 2024 16:47
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_properties

@martha-johnston
Copy link
Contributor Author

was having issues with the auto generated protos, resolved by committing everything except app_grpc.py. when that file is generated, there is a new method RenameKey that causes all of the app client tests to fail. I can't find a ticket about adding RenameKey anywhere so I don't know what that's about, but is it alright to just include protos related to my change?

Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I'm going to try and merge some changes into main to help get your proto stuff unblocked, so I'll comment again when that's ready

@martha-johnston
Copy link
Contributor Author

Approving, but I'm going to try and merge some changes into main to help get your proto stuff unblocked, so I'll comment again when that's ready

thanks sounds good

@njooma
Copy link
Member

njooma commented May 31, 2024

Ok @martha-johnston please rebase main and you should be all set! no need to include your generated files -- everything should be fixed

@martha-johnston
Copy link
Contributor Author

thanks for the help @njooma

@martha-johnston martha-johnston merged commit 8bcd3db into viamrobotics:main May 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants