Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-4561] Remove unused check #624

Merged
merged 1 commit into from
May 22, 2024

Conversation

njooma
Copy link
Member

@njooma njooma commented May 21, 2024

When MovementSensor was still a subclass of Sensor, we had to exclude adding registering a Sensor subtype with the robot for every MovementSensor so as to not duplicate the available resources.

Now that MovementSensor is distinct from Sensor, we can remove that check

@njooma njooma requested a review from a team as a code owner May 21, 2024 21:31
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_properties

Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the only real change was the removal in client.py, and the other changes were formatting? If so, LGTM!

@njooma njooma merged commit cc1e715 into viamrobotics:main May 22, 2024
13 checks passed
@njooma njooma deleted the RSDK-5461/unused-check branch May 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants