Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc-0.21.0 #621

Merged
merged 11 commits into from
May 21, 2024
Merged

rc-0.21.0 #621

merged 11 commits into from
May 21, 2024

Conversation

njooma
Copy link
Member

@njooma njooma commented May 20, 2024

Let's merge in our breaking changes!!

@njooma njooma requested a review from a team as a code owner May 20, 2024 19:26
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_classifications_from_camera

Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all the individual commits already so just did a super cursory eye over, looks good to me!

Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot woot! 🎉 (same as Ethan, took a quick glance)

@njooma
Copy link
Member Author

njooma commented May 20, 2024

@viamrobotics/fleet-management camera.get_image was changed! What to do?

@DTCurrie
Copy link
Member

@viamrobotics/fleet-management camera.get_image was changed! What to do?

Start here, might be slightly outdated now that the code samples have moved to the ui svelte project, but it should be ok: https://viam.atlassian.net/wiki/spaces/ENG/pages/231473156/Code+Samples

@njooma
Copy link
Member Author

njooma commented May 21, 2024

@DTCurrie Thanks! Took a look, seems like we don't have to do anything because the return type isn't specified in the python examples

@njooma njooma merged commit 7c32272 into main May 21, 2024
12 checks passed
@njooma njooma deleted the rc-0.21.0 branch May 21, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants