RSDK-6907 StreamTicks API #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
njooma
requested changes
Apr 19, 2024
stuqdog
approved these changes
Apr 22, 2024
src/viam/components/board/board.py
Outdated
| @abc.abstractmethod | ||
| async def stream_ticks( | ||
| self, interrupts: List[DigitalInterrupt], *, timeout: Optional[float] = None, **kwargs | ||
| ) -> Stream[Tick]: |
There was a problem hiding this comment.
(minor) since we defined TickStream above, should we not use it here in the return?
njooma
approved these changes
Apr 22, 2024
njooma
pushed a commit
to njooma/viam-python-sdk
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes the
MediaStreamand moved tostreams.pyto use for digital interrupt streaming.