Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox to include typechecking #514

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

njooma
Copy link
Member

@njooma njooma commented Jan 4, 2024

Previously, I wrote the code to assume we were typechecking only on the most recent version of python. That proved short-sighted.

Fix the issues around type checking pre-py310, and update tox to also typecheck

@njooma njooma requested a review from a team as a code owner January 4, 2024 19:30
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_classifications_from_camera

@njooma njooma merged commit 3f5bd4d into viamrobotics:main Jan 4, 2024
13 checks passed
@njooma njooma deleted the typechecking branch January 4, 2024 21:37
nicksanford pushed a commit to nicksanford/viam-python-sdk that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants