RSDK-4447: Allow dial timeout to be configurable #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he socket connection call
njooma
requested changes
Sep 11, 2023
| @@ -66,6 +66,10 @@ class DialOptions: | |||
| if detected, even with credentials present. This is generally | |||
| unsafe to use, but can be requested.""" | |||
|
|
|||
| timeout: float = 20 | |||
| """Number of seconds before the dial connection times out | |||
| Set to 20sec to match _defaultOfferDeadline in goutils/rpc/wrtc_call_queue.go""" | |||
There was a problem hiding this comment.
This shouldn't be in the docstring -- it can be a comment, but it doesn't need to be publicly available in the docs
| @@ -280,7 +286,7 @@ async def _dial_direct(address: str, options: Optional[DialOptions] = None) -> C | |||
|
|
|||
| # Test if downgrade is required. | |||
| downgrade = False | |||
| with socket.create_connection((host, port)) as sock: | |||
| with socket.create_connection((host, port), timeout=opts.timeout) as sock: | |||
There was a problem hiding this comment.
This is only a test. The real socket connection happens in rust-utils. You'll probably have to change some rust-utils code to accept timeout as a parameter
|
Oh sorry just noticed this is still in draft and I probably didn't need to review it just yet oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-4447