-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APP-2517: org API key support #419
Conversation
Thanks for reviewing @stuqdog! Other than eventually merging the other ticket I put you in review for, viamrobotics/rust-utils#75, is there anything else I need to do before hitting merge on this one? |
I don't think anything needs to be done here specifically, but we'll want to coordinate the releases of rust-utils and the C++ sdk. There's plenty of leeway on releasing this first (we won't be cutting new releases until next Thursday) but might be good to coordinate the release of all three just to be safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on call and can help with the coordinated release candidate cutting on Thursday. nvm this is next thursday!
Did this mean that I should hold off on merging? Or is it safe to merge? I think safe but wanted to double-check. |
APP-2517
Requires changes to rust-utils, RSDK-4755
This script (in this case, with the little hacks in place to connect to a robot on localhost):
Will output this: