RSDK-4648: Document namespace nomenclature better #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hexbabe
force-pushed
the
RSDK-4648
branch
5 times, most recently
from
41cb777
to
0791bcb
Compare
added 2 commits
September 5, 2023 12:49
… to link to Andrew's updated docs about custom namespaces once that is up
|
Should I make the changes to simple and complex module on this PR instead? @cheukt |
|
ya, let's make them here |
ok i did it |
cheukt
requested changes
Sep 6, 2023
andf-viam
reviewed
Sep 8, 2023
Co-authored-by: andf-viam <[email protected]>
Co-authored-by: andf-viam <[email protected]>
Co-authored-by: andf-viam <[email protected]>
added 2 commits
September 8, 2023 13:14
…viam' namespace gizmo and service back to 'acme' because i dont think we have gizmo and summation service...; changed simple module code to be same as readme
hexbabe
commented
Sep 11, 2023
examples/complex_module/README.md
Outdated
| @@ -103,7 +103,7 @@ An example configuration for an Arm component, a Gizmo component, and a Summatio | |||
| "name": "mysum1", | |||
| "type": "summation", | |||
| "namespace": "acme", | |||
| "model": "viam:sum:mysum", | |||
| "model": "acme:demo:mysum", | |||
There was a problem hiding this comment.
I changed this back to acme because I did not see a sum or summation as a Viam-supported component as per the RDK repo
examples/complex_module/README.md
Outdated
| @@ -54,7 +54,7 @@ An example configuration for an Arm component, a Gizmo component, and a Summatio | |||
| "name": "gizmo1", | |||
| "type": "gizmo", | |||
| "namespace": "acme", | |||
| "model": "viam:gizmo:mygizmo", | |||
| "model": "acme:demo:mygizmo", | |||
There was a problem hiding this comment.
I changed this back to acme because I did not see a gizmo as a Viam-supported component as per the RDK repo
cheukt
requested changes
Sep 11, 2023
cheukt
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-4648
acmeand other non-standardized models to conform to new conventions