pr feedback

src/viam/components/board/board.py

@@ -1,4 +1,5 @@
 import abc
+from dataclass import dataclass
 from datetime import timedelta
 from typing import Any, Dict, Final, List, Optional
 
@@ -38,17 +39,22 @@ class Analog:
         name: str
         """The name of the analog pin"""
 
+        @dataclass
         class Value:
             """
-            Data obtained from reading an analog pin. The value is the raw bits obtained, while the
-            range indicates indicates the what the extreme values indicate. The step_size is the
-            precision per bit of the reading. The value read, when interpreted in
-            volts/degrees/etc., is (min_range + value * step_size)
+            Data obtained from reading an analog pin.
             """
             value: int
+            """The raw bits from the analog reader"""
+
             min_range: float
+            """The minimum value the analog reader can output"""
+
             max_range: float
+            """The maximum value the analog reader can output"""
+
             step_size: float
+            """The precision per bit of the reading"""
 
         def __init__(self, name: str):
             self.name = name

src/viam/components/board/client.py

@@ -53,11 +53,8 @@ async def read(
             extra = {}
         request = ReadAnalogReaderRequest(board_name=self.board.name, analog_reader_name=self.name, extra=dict_to_struct(extra))
         response: ReadAnalogReaderResponse = await self.board.client.ReadAnalogReader(request, timeout=timeout)
-        result = self.Value()
-        result.value = response.value
-        result.min_range = response.min_range
-        result.max_range = response.max_range
-        result.step_size = response.step_size
+        result = self.Value(value=response.value, min_range=response.min_range,
+                            max_range=response.max_range, step_size=response.step_size)
         return result
 
     async def write(

tests/mocks/components.py

@@ -231,11 +231,7 @@ async def do_command(self, command: Mapping[str, ValueTypes], *, timeout: Option
 
 class MockAnalog(Board.Analog):
     def __init__(self, name: str, value: int, min_range: float, max_range: float, step_size: float):
-        self.value = self.Value()
-        self.value.value = value
-        self.value.min_range = min_range
-        self.value.max_range = max_range
-        self.value.step_size = step_size
+        self.value = self.Value(value=value, min_range=min_range, max_range=max_range, step_size=step_size)
         self.timeout: Optional[float] = None
         super().__init__(name)