RSDK-4058 Add PowerSensor Component #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
requested changes
Aug 2, 2023
Comment on lines
7
to
27
| class Voltage { | ||
| double volts; | ||
| bool isAc; | ||
|
|
||
| Voltage(this.volts, this.isAc); | ||
|
|
||
| factory Voltage.fromProto(GetVoltageResponse pbResponse) { | ||
| return Voltage(pbResponse.volts, pbResponse.isAc); | ||
| } | ||
| } | ||
|
|
||
| class Current { | ||
| double amperes; | ||
| bool isAc; | ||
|
|
||
| Current(this.amperes, this.isAc); | ||
|
|
||
| factory Current.fromProto(GetCurrentResponse pbResponse) { | ||
| return Current(pbResponse.amperes, pbResponse.isAc); | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of creating these types which are identical to the response type (but with better names), you can just create typedefs that should do the same thing:
typedef Voltage = GetVoltageResponse;
typedef Current = GetCurrentResponse;You will have to change a bit of the code, but this way you don't have to create brand new classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope: https://docs.google.com/document/d/1HjShXMyD6HQkZkAo0bvDe61STdxxfyBrVnbRC6nSlM0/edit