-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-4265] Widgets #78
Conversation
iconTrailing; | ||
} | ||
|
||
class ViamButton extends StatelessWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the use of a viamButton? does this mean rather than someone using an ElevatedButton from flutter and styling it to match the viam theme, then they could just use a viamButton? Or is there greater functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's basically just that -- just a button that's always going to be styled for Viam (regardless of what your theme is). I mostly made this for use internally for any/all buttons in the SDK widgets, and figured we might as well publish it like we do for PRIME.
@@ -1,15 +1,16 @@ | |||
import 'package:flutter/material.dart'; | |||
import 'package:flutter_platform_widgets/flutter_platform_widgets.dart'; | |||
import 'package:viam_sdk/viam_sdk.dart'; | |||
import 'package:viam_sdk/widgets.dart'; | |||
|
|||
class BaseScreen extends StatelessWidget { | |||
final Base base; | |||
final ResourceName resourceName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need resourceName still? is it being used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't. I left it in because all the other screens still have ResourceName
. I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one potential change and the other comments are for my understanding, LGTM
Adding widgets to the flutter sdk. Eventually this will be built out more, so I will be using this branch to add more widgets and merge them in.