[hotfix] resource names #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
approved these changes
Nov 21, 2024
lib/src/resource/manager.dart
Outdated
| if (resources.containsKey(name)) { | ||
| resource = resources[name]; | ||
| } else { | ||
| final resourcesWithoutRemotes = resources.map((rn, res) { |
There was a problem hiding this comment.
(q) Potentially out of scope for a hotfix but, should resourcesWithoutRemotes live on the ResourceManager such that we don't have to construct this new map potentially every time we call getResource?
There was a problem hiding this comment.
Did it anyway -- it's a good thought
stuqdog
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the way we create resources names when only given a name. It also updates the resource manager to look for short names when long names don't return anything