-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-9281] Add native type return to Flutter SDK DiscoverComponents #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. my only q/comment is who will be reading these results? looking at the photo you included for local testing, the results are a bit difficult for a user to interpret (it is hard to tell if the nested discovery objects are related to the top-level component?). however, if this is primarily for internal use, than I can understand priorities might be different
Really good point. This is a point of discussion with AV and mobile right now. I think this is a good initial step though https://viaminc.slack.com/archives/C07GTSXSVEC/p1731708356210009?thread_ts=1731688631.621549&cid=C07GTSXSVEC |
I do still agree with this point, on the frontend right now I'm playing around with getting this to something useable and it's tricky. The json string for the cameras in the results looks like this:
After calling Though talking with the mobile team, there could be some easy step I'm missing |
Q: why use native type? is it because the results are even more difficult to read as raw proto? |
If there was a proto for the results / a result maybe not? 🤔 |
Clarification: you mean if |
Exactly, sorry if my wording is off I haven't really worked w/ proto buffers / grpc |
Though to provide more context, in the current app we're working on, when working with a robotConfig it's a bit easier to work with when converted to a map (and it's a pb struct) |
The question that is currently blocking this PR is: can we make this even better for mobile? And it looks like the answer is no unless we change the proto
OK with me merging this? @kevin49999 @jckras @njooma |
Let's not merge yet unless it's blocking something. There should be a way to fix the nested struct keys |
Please see new util handler to unwrap nested "Kind" and "fields" wrappers |
Further conversations were had and we are not going forward with a unwrapper https://viaminc.slack.com/archives/C07GTSXSVEC/p1732050452559639?thread_ts=1731688631.621549&cid=C07GTSXSVEC |
RSDK-9281
Add native type return to Flutter SDK DiscoverComponents
Tested locally