Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send empty session id when sessions disabled #277

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Do not send empty session id when sessions disabled #277

merged 1 commit into from
Oct 21, 2024

Conversation

clintpurser
Copy link
Member

before this change If I disabled sessions in dialOptions I would get an error whenever making a call to a robot.

gRPC Error (code: 2, codeName: UNKNOWN, message: invalid UUID length: 0, details: [], rawResponse: null, trailers: {})

@clintpurser clintpurser requested a review from a team as a code owner October 16, 2024 13:34
@njooma njooma merged commit 4d5f6b9 into viamrobotics:main Oct 21, 2024
4 checks passed
@njooma njooma mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@lia-viam lia-viam Awaiting requested review from lia-viam lia-viam is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clintpurser @njooma