Add shutdown function (#256)

* Add shutdown function * Add macros to license finder
viamrobotics · Aug 26, 2024 · a94beaa · a94beaa
1 parent 514364b
commit a94beaa
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 16 deletions.
diff --git a/doc/dependency_decisions.yml b/doc/dependency_decisions.yml
@@ -83,3 +83,9 @@
     :why: License is Apache License, Version 2.0
     :versions: []
     :when: 2024-05-16 20:49:48.048674000 Z
+- - :approve
+  - _macros
+  - :who: njooma
+    :why: License is BSD 3-Clause
+    :versions: []
+    :when: 2024-08-26 20:13:45.308837000 Z
diff --git a/lib/src/rpc/dial.dart b/lib/src/rpc/dial.dart
@@ -612,19 +612,3 @@ _HostAndPort _hostAndPort(String address, bool insecure) {
   }
   return _HostAndPort(host, port);
 }
-
-/// A channel that adds session data (if required) to gRPC metadata for every call
-class ClientChannelWithSessions extends GrpcOrGrpcWebClientChannel {
-  final String Function() _sessionId;
-
-  ClientChannelWithSessions.toSingleEndpoint(this._sessionId, {required super.host, required super.port, required super.transportSecure})
-      : super.toSingleEndpoint();
-
-  @override
-  ClientCall<Q, R> createCall<Q, R>(ClientMethod<Q, R> method, Stream<Q> requests, CallOptions options) {
-    if (!SessionsClient.unallowedMethods.contains(method.path)) {
-      options = options.mergedWith(CallOptions(metadata: {SessionsClient.sessionMetadataKey: _sessionId()}));
-    }
-    return super.createCall(method, requests, options);
-  }
-}
diff --git a/lib/src/rpc/web_rtc/web_rtc_client.dart b/lib/src/rpc/web_rtc/web_rtc_client.dart
@@ -35,4 +35,11 @@ class WebRtcClientChannel extends ClientChannelBase {
     options = options.mergedWith(CallOptions(metadata: {'viam_client': getVersionMetadata()}));
     return super.createCall(method, requests, options);
   }
+
+  @override
+  Future<void> shutdown() async {
+    await rtcPeerConnection.close();
+    await dataChannel.close();
+    return super.shutdown();
+  }
 }