-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conan shared builds and conan CI RSDK-9113 #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to gather context for my own understanding:
- How are shared libraries being used in cpp-sdk? does the shared-ness refer to whether libraries are being compiled as shared or static?
- what do you mean by the "shared-ness of grpc and protobuf needs to match our shared-ness"... the way we compile gRPC and protobuf libraries must be the same as the way we compile our project?
Exactly!
That part is a bit vague and Drew suggested elaborating on it as well but yes, we need a shared grpc/proto for a shared SDK build and vice versa, going to update that comment and also elaborate on it |
Just sharing this for reference/discussion: |
It turns out shared library builds have been broken all along with conan and I did not realize because the test_package was not meaningfully testing the library, but then I further did not realize because the cron + new commits dispatch for the conan job was broken. This PR