Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conan shared builds and conan CI RSDK-9113 #309

Merged
merged 33 commits into from
Nov 7, 2024

Conversation

lia-viam
Copy link
Contributor

It turns out shared library builds have been broken all along with conan and I did not realize because the test_package was not meaningfully testing the library, but then I further did not realize because the cron + new commits dispatch for the conan job was broken. This PR

  • fixes shared builds
  • changes the CI trigger for the conan job

@lia-viam lia-viam requested a review from a team as a code owner October 22, 2024 18:44
@lia-viam lia-viam requested review from njooma and jckras and removed request for a team October 22, 2024 18:44
conanfile.py Show resolved Hide resolved
.github/workflows/conan.yml Outdated Show resolved Hide resolved
conanfile.py Outdated Show resolved Hide resolved
conanfile.py Outdated Show resolved Hide resolved
conanfile.py Outdated Show resolved Hide resolved
Copy link
Member

@jckras jckras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to gather context for my own understanding:

  • How are shared libraries being used in cpp-sdk? does the shared-ness refer to whether libraries are being compiled as shared or static?
  • what do you mean by the "shared-ness of grpc and protobuf needs to match our shared-ness"... the way we compile gRPC and protobuf libraries must be the same as the way we compile our project?

@lia-viam
Copy link
Contributor Author

@jckras

* How are shared libraries being used in cpp-sdk? does the shared-ness refer to whether libraries are being compiled as shared or static?

Exactly!

* what do you mean by the "shared-ness of grpc and protobuf needs to match our shared-ness"... the way we compile gRPC and protobuf libraries must be the same as the way we compile our project?

That part is a bit vague and Drew suggested elaborating on it as well but yes, we need a shared grpc/proto for a shared SDK build and vice versa, going to update that comment and also elaborate on it

conanfile.py Outdated Show resolved Hide resolved
test_package/conanfile.py Outdated Show resolved Hide resolved
@lia-viam lia-viam changed the base branch from fix/conan-ci to main October 30, 2024 21:59
@lia-viam
Copy link
Contributor Author

lia-viam commented Nov 4, 2024

Just sharing this for reference/discussion:
conan-io/conan-center-index#23421

@lia-viam lia-viam merged commit 40d6135 into viamrobotics:main Nov 7, 2024
13 checks passed
@lia-viam lia-viam deleted the fix/conan-ci branch November 7, 2024 17:30
@10zingpd 10zingpd changed the title Fix conan shared builds and conan CI Fix conan shared builds and conan CI RSDK-9113 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants