APP-6070 Update apis.json to use new fields #284
+55
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplenicole730
approved these changes
Sep 9, 2024
|
@DTCurrie checking in -- can we merge? |
I was going to make another pass to clean up some of the streamable vs. not-streamable returns. So I’d prefer to keep it open, but if it’s annoying we can merge it, we just need to wait until after the deploy today so I have a chance to get the app side changes reviewed. |
|
Nope all good we can leave open. I'm just going through all my review requests so wanted to double check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
apis.jsonfile to use the new fields we use for code sample generation. See similar changes for the Python SDK, RDK, and TS-SDK.It's important to note the TS-SDK and CPP-SDK had a departure from other SDKs where they declared a
clientfield. I have updated that to useimportNameto match other code sample implementations.