RSDK-2069 - Fix proto generation #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
maximpertsov and
jckras
and removed request for
a team
jckras
reviewed
Aug 2, 2023
| @@ -87,11 +87,6 @@ if (VIAMCPPSDK_USE_DYNAMIC_PROTOS) | |||
| config/buf.gen.remote.plugin.yaml.in | |||
| buf.gen.yaml | |||
| ) | |||
| elseif ((NOT VIAMCPPSDK_OFFLINE_PROTO_GENERATION) AND (VIAMCPPSDK_GRPCXX_VERSION VERSION_GREATER_EQUAL 1.41.1)) | |||
There was a problem hiding this comment.
I remember having to turn these flags on in the command line to avoid problems in github when testing the submitted code and they helped with debugging. Why are we getting rid of them?
jckras
approved these changes
Aug 2, 2023
acmorrow
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.