Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RSDK-8982, RSDK-9167, RSDK-8979] - Add SetStreamOptions to stream server #4530

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

[RSDK-8982, RSDK-9167, RSDK-8979] - Add SetStreamOptions to stream server #4530

wants to merge 24 commits into from

Commits on Nov 5, 2024

  1. Add basic set stream options

    @seanavery
    seanavery committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7634a56 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Make sure video track survives resize

    @seanavery
    seanavery committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    08ee02e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Test that video tracks survive setting stream options

    @seanavery
    seanavery committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1d4d5b3 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate validation

    @seanavery
    seanavery committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    47193fe View commit details
    Browse the repository at this point in the history

  3. Add read lock to GetStreamOptions

    @seanavery
    seanavery committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    686dbb6 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Use %q when logging name

    @seanavery
    seanavery committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d0d0c5c View commit details
    Browse the repository at this point in the history

  2. Add resize state transition

    @seanavery
    seanavery committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3bd8e98 View commit details
    Browse the repository at this point in the history

  3. Lint

    @seanavery
    seanavery committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c95ea9d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Check resize err

    @seanavery
    seanavery committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    eef2ab1 View commit details
    Browse the repository at this point in the history

  2. Add test for resize downgrade path

    @seanavery
    seanavery committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9f77dd9 View commit details
    Browse the repository at this point in the history

  3. Improve state handler to avoid passthrough attempts when in resize mode

    @seanavery
    seanavery committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    95315d4 View commit details
    Browse the repository at this point in the history

  4. Add test cases that ensure we avoid passthrough attempts when resized

    @seanavery
    seanavery committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    cd74a13 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Simplify locking

    @seanavery
    seanavery committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2c222eb View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Change to isResized

    @seanavery
    seanavery committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    50a6fbf View commit details
    Browse the repository at this point in the history

  2. Add more info in error returns

    @seanavery
    seanavery committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    56b8f2a View commit details
    Browse the repository at this point in the history

  3. Use t.Run for stream tests

    @seanavery
    seanavery committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ef3dff0 View commit details
    Browse the repository at this point in the history

  4. Use t.Run for stream state tests

    @seanavery
    seanavery committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5a52a36 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Remove read lock

    @seanavery
    seanavery committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f5ef994 View commit details
    Browse the repository at this point in the history

  2. Create validation helper

    @seanavery
    seanavery committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fb9eac5 View commit details
    Browse the repository at this point in the history

  3. Move all resize logic into resizeVideoSource

    @seanavery
    seanavery committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c41c2df View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Add reset path to exit resized mode

    @seanavery
    seanavery committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6a5292c View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Directly swap with cam

    @seanavery
    seanavery committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    37174cf View commit details
    Browse the repository at this point in the history

  2. Overwrite sequence number

    @seanavery
    seanavery committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    424c3b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Move validate fn

    @seanavery
    seanavery committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    2956cde View commit details
    Browse the repository at this point in the history