RSDK-9058: remove tflite from rdk #4476
Conversation
viambot
added
the
safe to test
viambot
added
safe to test
| @@ -179,7 +179,7 @@ jobs: | |||
| --platform linux/arm/v7 \ | |||
| -v `pwd`:/rdk \ | |||
| ghcr.io/viamrobotics/rdk-devenv:armhf-cache \ | |||
| sudo -Hu testbot bash -lc 'sudo apt-get install -y python3-venv && cd /rdk && go test -v -tags=no_tflite ./...' | |||
| sudo -Hu testbot bash -lc 'sudo apt-get install -y python3-venv && cd /rdk && go test -v ./...' | |||
There was a problem hiding this comment.
@abe-winter I assume it's all right to remove all instances of the no_tflite tag from the RDK now?
There was a problem hiding this comment.
yes OR hear me out we can put the no_tflite flag on every file to commemorate this change
There was a problem hiding this comment.
@abe-winter the vision service register was split into two go files, register.go and register_cgo.go, can they be combined now?
There was a problem hiding this comment.
probably -- if you can still make full-static after that change, it's okay to do
| @@ -1,5 +1,3 @@ | |||
| //go:build !no_tflite | |||
There was a problem hiding this comment.
cc @hexbabe, now we can probably move the static source to live with its videosourcewrapper counterparts since there's the weird flite test build dependency circus is gone.
viambot
added
safe to test
| @@ -5,7 +5,7 @@ FROM $MAIN_TAG:$BASE_TAG as builder | |||
| COPY --chown=1000:1000 ./ /tmp/rdk | |||
| WORKDIR /tmp/rdk | |||
| RUN --mount=type=secret,id=netrc,uid=1000,dst=/home/testbot/.netrc sudo -Hu testbot bash -lc 'if [ `dpkg --print-architecture` = armhf ]; then \ | |||
| GOFLAGS=-tags=no_tflite make build-go tool-install; \ | |||
| make build-go tool-install; \ | |||
There was a problem hiding this comment.
you also want to remove the offending package from /etc/ld_wrapper.sh
viambot
added
safe to test
| @@ -23,7 +23,6 @@ jobs: | |||
| brew install x264 | |||
| brew install jpeg-turbo | |||
| brew install ffmpeg | |||
| brew install tensorflowlite # Needs to be last | |||
There was a problem hiding this comment.
this step is very slow, awesome to remove
This is a big change for RDK that removes all instances of tflite from the repo. These will be the following breaking changes
rdk:builtin:tflite_cpumodel from the ml_model service. It is now only available as a moduleThis also creates a "fake" vision model in order to replace necessary tests in the transform camera.
@randhid FYI