Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-8681 display arm error message in degrees not radians #4441

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

raybjork
Copy link
Member

No description provided.

Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision GetProperties

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Oct 10, 2024
@@ -187,16 +188,19 @@ func CheckDesiredJointPositions(ctx context.Context, a Arm, desiredInputs []refe
max := limits[i].Max
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also could see an argument for changing the function signature to accept *pb.JointPositions instead of []referenceframe.Input since that way we are returning the error in the units in the same units they are provided. But I'm not sure this is a great idea since it seems likely we will continue to prefer Inputs over pb.JointPositions as we continue to develop arms and would rather avoid the extra breaking change to the package and modules that depend on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cost of having a slightly unintuitive error here is probably worth keeping the package contract stable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my opinion is that we should not accept *pb.JointPositions as an argument into functions, so we should keep it as is.

@raybjork raybjork merged commit 16647cf into viamrobotics:main Oct 10, 2024
21 checks passed
@raybjork raybjork deleted the errormsg branch October 10, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants