Move more of the videosource code to the videosourcewrappers file #4366
Conversation
viambot
added
the
safe to test
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
Not according to my tests, but we'll see what CI says. |
| logging.Logger | ||
| } | ||
|
|
||
| func (vs *sourceBasedCamera) SubscribeRTP( |
There was a problem hiding this comment.
[q] Trying to figure out why we define SubscribeRTP and Unsubscribe for both sourceBasedCamera and videoSource.
There was a problem hiding this comment.
They're both implementing a VideoSource go interface interface/class, which can optionally have a SubscribeRTP method. There are other implementations of the VideoSource interface, for example filesource which is used in image_file. All of these structs implement the Camera/VideoSource methods, and can optionally implement Subscribe/UnsubscribeRTP to allow the RTP packet pass-through that @nicksanford wrote to be used by a camera's implementation.
There was a problem hiding this comment.
This is also why in the constructors for different go cameras, we use the helper functions in this file to make one of the video sources that implements all of these methods. It's an example of trying ot use single point of truth/dry.
This pr simply moves code around so that the structs implementing videosources are all in one file.