RSDK-8116 allow node16 in antique #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
dgottlieb
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Why
actions/checkout suddenly started using node20 which added a GLIBC 2.28 dependency (see actions/checkout#1809).
This is fine for us in most places, but our compatibility build is intentionally on an old linux that has old GLIBC.
Test run
Here, works:
https://github.com/viamrobotics/rdk/actions/runs/9845816473/job/27182189699
Follow-ups
At some point node16 will be removed and we'll need to find a new option, probably overwriting the runner's node20 dist on start.