Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-7885: Call networking tests trigger workflow in rc workflow #4115

Conversation

danielbotros
Copy link
Contributor

Description

  • RSDK-7885: Run Networking Tests on release Candidate
  • See these PRs:
    • This PR modifies Networking Tests workflow to be able to be triggered by new-rc-branch events sent by remote repositories
    • This PR creates a new workflow in the RDK which sends a new-rc-branch event to the sdk-integration-tests repo which triggers the Networking Tests
  • This final PR makes a workflow-call from the RC workflow to the trigger-network-tests workflow triggering Networking Tests in the sdk-integration-tests repo

Testing

You can manually run the "Trigger Networking Tests in sdk-integration-tests" workflow from the Actions tab and see that Networking Tests will be triggered in the sdk-integration-tests repo

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jun 20, 2024
run-sdk-integration-networking-tests:
needs: [staticbuild, appimage]
if: ${{ success() }}
uses: ./trigger-networking-tests.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also re-integrate this workflow back into the rc workflow, but this current set-up makes it reusable by other workflows if needed in the future

@danielbotros danielbotros changed the title Call networking tests trigger workflow in rc workflow RSDK-7885: Call networking tests trigger workflow in rc workflow Jun 20, 2024
Copy link
Contributor

@maximpertsov maximpertsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for automating this workflow 🫡

@danielbotros danielbotros force-pushed the RSDK-7855-add-repo-dispatch-event-to-rc-workflow branch from 054a6b1 to cedf7a3 Compare June 21, 2024 16:52
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 21, 2024
@danielbotros danielbotros merged commit d9ea66c into viamrobotics:main Jun 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants