Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-4829 32-bit build tags #2906

Merged
merged 2 commits into from
Sep 13, 2023
Merged

RSDK-4829 32-bit build tags #2906

merged 2 commits into from
Sep 13, 2023

Conversation

abe-winter
Copy link
Member

What

  • this adds no_tflite and no_pigpio build flags, which can be used to toggle off tensorflow lite and pi GPIO libraries so that people can make 32-bit builds
  • this is part of closed giant PR RSDK-4829 arm32 build #2790
  • note: I excluded changes to test files; will add those back when we do 32-bit tests in CI

Using this

  • go build -tags no_tflite,no_pigpio ./web/cmd/server

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Sep 12, 2023
@abe-winter abe-winter changed the title 32-bit build tags RSDK-4829 32-bit build tags Sep 12, 2023
@github-actions
Copy link
Contributor

Code Coverage

Code Coverage
Package Line Rate Delta Health
go.viam.com/rdk/cli 11% 0.00% ❌
go.viam.com/rdk/components/arm 58% 0.00% ➖
go.viam.com/rdk/components/arm/fake 27% 0.00% ❌
go.viam.com/rdk/components/arm/universalrobots 42% 0.00% ❌
go.viam.com/rdk/components/arm/wrapper 19% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 22% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 43% -0.47% ❌
go.viam.com/rdk/components/base 60% 0.00% ➖
go.viam.com/rdk/components/base/agilex 60% 0.00% ➖
go.viam.com/rdk/components/base/kinematicbase 36% 0.00% ❌
go.viam.com/rdk/components/base/sensorbase 68% 0.00% ➖
go.viam.com/rdk/components/base/wheeled 89% 0.00% ✅
go.viam.com/rdk/components/board 59% 0.00% ➖
go.viam.com/rdk/components/board/customlinux 50% 0.00% ➖
go.viam.com/rdk/components/board/fake 38% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 8% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi/impl 11% N/A ❌
go.viam.com/rdk/components/camera 57% 0.00% ➖
go.viam.com/rdk/components/camera/align 58% 0.00% ➖
go.viam.com/rdk/components/camera/fake 74% 0.00% ✅
go.viam.com/rdk/components/camera/ffmpeg 82% 0.00% ✅
go.viam.com/rdk/components/camera/replaypcd 90% 0.00% ✅
go.viam.com/rdk/components/camera/rtsp 52% 0.00% ➖
go.viam.com/rdk/components/camera/transformpipeline 73% 0.00% ✅
go.viam.com/rdk/components/camera/ultrasonic 61% 0.00% ➖
go.viam.com/rdk/components/camera/videosource 39% 0.00% ❌
go.viam.com/rdk/components/encoder 56% 0.00% ➖
go.viam.com/rdk/components/encoder/ams 63% 0.00% ➖
go.viam.com/rdk/components/encoder/fake 83% 0.00% ✅
go.viam.com/rdk/components/encoder/incremental 80% 0.00% ✅
go.viam.com/rdk/components/encoder/single 86% 0.00% ✅
go.viam.com/rdk/components/gantry 58% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 82% 0.00% ✅
go.viam.com/rdk/components/gantry/singleaxis 83% +1.67% ✅
go.viam.com/rdk/components/generic 79% 0.00% ✅
go.viam.com/rdk/components/gripper 56% 0.00% ➖
go.viam.com/rdk/components/input 88% 0.00% ✅
go.viam.com/rdk/components/input/fake 93% 0.00% ✅
go.viam.com/rdk/components/input/gpio 85% 0.00% ✅
go.viam.com/rdk/components/motor 70% 0.00% ➖
go.viam.com/rdk/components/motor/dimensionengineering 67% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 70% 0.00% ➖
go.viam.com/rdk/components/motor/fake 55% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 73% 0.00% ✅
go.viam.com/rdk/components/motor/gpiostepper 72% 0.00% ✅
go.viam.com/rdk/components/motor/tmcstepper 53% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 53% 0.00% ➖
go.viam.com/rdk/components/movementsensor 74% 0.00% ✅
go.viam.com/rdk/components/movementsensor/adxl345 75% 0.00% ✅
go.viam.com/rdk/components/movementsensor/gpsnmea 55% 0.00% ➖
go.viam.com/rdk/components/movementsensor/gpsrtkpmtk 21% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtkserial 28% 0.00% ❌
go.viam.com/rdk/components/movementsensor/merged 91% 0.00% ✅
go.viam.com/rdk/components/movementsensor/mpu6050 84% 0.00% ✅
go.viam.com/rdk/components/movementsensor/replay 93% 0.00% ✅
go.viam.com/rdk/components/movementsensor/rtkutils 24% 0.00% ❌
go.viam.com/rdk/components/movementsensor/wheeledodometry 78% 0.00% ✅
go.viam.com/rdk/components/posetracker 71% 0.00% ✅
go.viam.com/rdk/components/powersensor 48% 0.00% ❌
go.viam.com/rdk/components/sensor 49% 0.00% ❌
go.viam.com/rdk/components/sensor/ultrasonic 38% 0.00% ❌
go.viam.com/rdk/components/servo 60% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 72% 0.00% ✅
go.viam.com/rdk/config 81% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 73% -4.48% ✅
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/internal/cloud 100% 0.00% ✅
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 67% 0.00% ➖
go.viam.com/rdk/module 75% 0.00% ✅
go.viam.com/rdk/module/modmanager 82% 0.00% ✅
go.viam.com/rdk/motionplan 78% -0.26% ✅
go.viam.com/rdk/motionplan/ik 68% 0.00% ➖
go.viam.com/rdk/motionplan/tpspace 52% 0.00% ➖
go.viam.com/rdk/operation 83% 0.00% ✅
go.viam.com/rdk/pointcloud 67% 0.00% ➖
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 69% 0.00% ➖
go.viam.com/rdk/resource 77% 0.00% ✅
go.viam.com/rdk/rimage 55% 0.00% ➖
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 70% +0.10% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 85% 0.00% ✅
go.viam.com/rdk/robot/client 82% 0.00% ✅
go.viam.com/rdk/robot/framesystem 36% 0.00% ❌
go.viam.com/rdk/robot/impl 83% 0.00% ✅
go.viam.com/rdk/robot/packages 75% 0.00% ✅
go.viam.com/rdk/robot/server 55% 0.00% ➖
go.viam.com/rdk/robot/web 65% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol 50% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol/builtin 81% 0.00% ✅
go.viam.com/rdk/services/datamanager 65% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 89% -0.49% ✅
go.viam.com/rdk/services/datamanager/datacapture 73% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/mlmodel 76% 0.00% ✅
go.viam.com/rdk/services/mlmodel/tflitecpu 85% 0.00% ✅
go.viam.com/rdk/services/motion 52% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 76% 0.00% ✅
go.viam.com/rdk/services/navigation 47% 0.00% ❌
go.viam.com/rdk/services/navigation/builtin 87% 0.00% ✅
go.viam.com/rdk/services/sensors 81% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 11% 0.00% ❌
go.viam.com/rdk/services/slam 73% 0.00% ✅
go.viam.com/rdk/services/slam/fake 82% 0.00% ✅
go.viam.com/rdk/services/vision 35% 0.00% ❌
go.viam.com/rdk/services/vision/colordetector 56% 0.00% ➖
go.viam.com/rdk/services/vision/detectionstosegments 67% 0.00% ➖
go.viam.com/rdk/services/vision/mlvision 64% -0.54% ➖
go.viam.com/rdk/services/vision/obstaclesdepth 78% 0.00% ✅
go.viam.com/rdk/services/vision/obstaclesdistance 77% 0.00% ✅
go.viam.com/rdk/services/vision/obstaclespointcloud 59% 0.00% ➖
go.viam.com/rdk/session 94% 0.00% ✅
go.viam.com/rdk/spatialmath 82% -0.09% ✅
go.viam.com/rdk/utils 65% 0.00% ➖
go.viam.com/rdk/utils/contextutils 38% 0.00% ❌
go.viam.com/rdk/vision 37% 0.00% ❌
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 69% 0.00% ➖
go.viam.com/rdk/vision/segmentation 54% 0.00% ➖
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 61% (23331 / 38039) -0.72% ➖

@abe-winter abe-winter marked this pull request as ready for review September 12, 2023 20:04
@dgottlieb
Copy link
Member

All looks fine to me, but I'll defer to James

Otterverse
Otterverse approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only concern is the new tags probably need to be documented. But now that Steve let us know we're going to start actually publishing/supporting 32-bit builds soon, I think it's okay to wait for a future PR and add comments/docs/makefile targets along with whatever upcoming additions are going to be needed to use this.

@abe-winter abe-winter merged commit e2cd980 into viamrobotics:main Sep 13, 2023
11 checks passed
@abe-winter abe-winter deleted the 32bit-build-tags branch September 13, 2023 17:01
bazile-clyde pushed a commit to bazile-clyde/rdk that referenced this pull request Jan 5, 2024
@abe-winter
RSDK-4829 32-bit build tags (viamrobotics#2906)
50ff563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Otterverse Otterverse Otterverse approved these changes

@dgottlieb dgottlieb dgottlieb approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abe-winter @dgottlieb @Otterverse @viambot