[RSDK-8859][RSDK-8386] Remove raspberry pi built-in model, test workf…

…lows and ld flag for static library. (#4397)

.github/workflows/test.yml

@@ -181,25 +181,6 @@ jobs:
           ghcr.io/viamrobotics/rdk-devenv:armhf-cache \
           sudo -Hu testbot bash -lc 'cd /rdk && go test -v -tags=no_tflite ./...'
 
-  test_pi:
-    name: Test Raspberry Pi Code
-    runs-on: pi4
-    timeout-minutes: 5
-
-    steps:
-    - name: Clean workspace
-      run: |
-        shopt -s dotglob
-        sudo chown -R `whoami` ./
-        rm -rf ./*
-
-    - uses: actions/checkout@v3
-      with:
-        ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || github.ref }}
-
-    - name: Run go unit tests on Pi
-      run: make test-pi
-
   motion_tests:
     name: Test Longer-running Motion Plans if affected
     uses: viamrobotics/rdk/.github/workflows/motion-tests.yml@main
@@ -257,20 +238,18 @@ jobs:
 
   test_passing:
     name: All Tests Passing
-    needs: [test_go, test_web_e2e, test_pi, test32, motion_tests]
+    needs: [test_go, test_web_e2e, test32, motion_tests]
     runs-on: [ubuntu-latest]
     if: always()
     steps:
       - name: Check Results
         run: |
           echo Go Unit Tests: ${{ needs.test_go.result }}
           echo Go 32-bit Tests: ${{ needs.test32.result }}
-          echo Go Pi Tests: ${{ needs.test_pi.result }}
           echo Web/E2E Tests: ${{ needs.test_web_e2e.result }}
           echo Motion Tests: ${{ needs.motion_tests.result }}
           [ "${{ needs.test_go.result }}" == "success" ] && \
           [ "${{ needs.test32.result }}" == "success" ] && \
-          [ "${{ needs.test_pi.result }}" == "success" ] && \
           [ "${{ needs.test_web_e2e.result }}" == "success" ] && \
           [ "${{ needs.motion_tests.result }}" == "success" ]
 

Makefile

@@ -93,11 +93,6 @@ test-go-no-race: tool-install
 test-web:
 	npm run test:unit --prefix web/frontend
 
-# test.short skips tests requiring external hardware (motors/servos)
-test-pi:
-	go test -c -o $(BIN_OUTPUT_PATH)/test-pi go.viam.com/rdk/components/board/pi/impl
-	sudo $(BIN_OUTPUT_PATH)/test-pi -test.short -test.v
-
 test-e2e:
 	go build $(LDFLAGS) -o bin/test-e2e/server web/cmd/server/main.go
 	./etc/e2e.sh -o 'run' $(E2E_ARGS)

components/board/config.go

@@ -5,7 +5,7 @@ import "go.viam.com/rdk/resource"
 // SPIConfig enumerates a specific, shareable SPI bus.
 type SPIConfig struct {
 	Name      string `json:"name"`
-	BusSelect string `json:"bus_select"` // "0" or "1" for main/aux in libpigpio
+	BusSelect string `json:"bus_select"` // "0" or "1" are common on single board computers
 }
 
 // Validate ensures all parts of the config are valid.