[RSDK-1273] Error return from intelrealserver causes panic in gostream (

#1870)

components/camera/videosource/helpers.go

@@ -6,6 +6,7 @@ import (
 	"image"
 	"io"
 	"net/http"
+	"strings"
 
 	"github.com/edaniels/golog"
 	"github.com/edaniels/gostream"
@@ -22,6 +23,10 @@ import (
 // detected by http.DetectContentType.
 func getMIMETypeFromData(ctx context.Context, data []byte) (string, error) {
 	detectedMimeType := http.DetectContentType(data)
+	if !strings.Contains(detectedMimeType, "image") {
+		return "", errors.Errorf("cannot decode image from MIME type '%s'", detectedMimeType)
+	}
+
 	requestedMime := gostream.MIMETypeHint(ctx, "")
 	actualMime, isLazy := utils.CheckLazyMIMEType(requestedMime)
 	if actualMime == utils.MimeTypeRawRGBA {

components/camera/videosource/server_test.go

@@ -213,3 +213,27 @@ func TestDualServerSource(t *testing.T) {
 	test.That(t, pc2, test.ShouldResemble, pc1)
 	test.That(t, cam2.Close(context.Background()), test.ShouldBeNil)
 }
+
+func TestServerError(t *testing.T) {
+	logger := golog.NewTestLogger(t)
+	//nolint:dogsled
+	router, _, _, _ := createTestRouter(t)
+	svr := httptest.NewServer(router)
+	defer svr.Close()
+
+	attrs := ServerAttrs{
+		// we expect a 404 error of MIME type "text/plain"
+		URL:    svr.URL + "/bad_path",
+		Stream: "color",
+	}
+
+	cam, err := NewServerSource(context.Background(), &attrs, logger)
+	test.That(t, err, test.ShouldBeNil)
+
+	lazyCtx := gostream.WithMIMETypeHint(context.Background(), utils.WithLazyMIMEType(utils.MimeTypeJPEG))
+	img, release, err := camera.ReadImage(lazyCtx, cam)
+
+	test.That(t, err, test.ShouldNotBeNil)
+	test.That(t, img, test.ShouldBeNil)
+	test.That(t, release, test.ShouldBeNil)
+}