wip

data/collector_test.go

@@ -21,16 +21,25 @@ import (
 )
 
 var (
+	dummyTime      = time.Date(2024, time.January, 10, 23, 0, 0, 0, time.UTC)
 	structCapturer = CaptureFunc(func(ctx context.Context, _ map[string]*anypb.Any) (CaptureResult, error) {
 		return dummyStructReading, nil
 	})
 	binaryCapturer = CaptureFunc(func(ctx context.Context, _ map[string]*anypb.Any) (CaptureResult, error) {
 		return CaptureResult{
+			Timestamps: Timestamps{
+				TimeRequested: dummyTime,
+				TimeReceived:  dummyTime.Add(time.Second),
+			},
 			Type:     CaptureTypeBinary,
 			Binaries: []Binary{{Payload: dummyBytesReading}},
 		}, nil
 	})
 	dummyStructReading = CaptureResult{
+		Timestamps: Timestamps{
+			TimeRequested: dummyTime,
+			TimeReceived:  dummyTime.Add(time.Second),
+		},
 		Type:        CaptureTypeTabular,
 		TabularData: TabularData{dummyStructReadingProto},
 	}
@@ -50,13 +59,24 @@ func TestNewCollector(t *testing.T) {
 
 	// If not missing parameters, should not return an error.
 	c2, err2 := NewCollector(nil, CollectorParams{
+		DataType:      CaptureTypeTabular,
 		ComponentName: "name",
 		Logger:        logging.NewTestLogger(t),
 		Target:        NewCaptureBuffer("dir", nil, 50),
 	})
 
-	test.That(t, c2, test.ShouldNotBeNil)
 	test.That(t, err2, test.ShouldBeNil)
+	test.That(t, c2, test.ShouldNotBeNil)
+
+	c3, err3 := NewCollector(nil, CollectorParams{
+		DataType:      CaptureTypeBinary,
+		ComponentName: "name",
+		Logger:        logging.NewTestLogger(t),
+		Target:        NewCaptureBuffer("dir", nil, 50),
+	})
+
+	test.That(t, err3, test.ShouldBeNil)
+	test.That(t, c3, test.ShouldNotBeNil)
 }
 
 // Test that the Collector correctly writes the SensorData on an interval.
@@ -290,6 +310,7 @@ func TestLogErrorsOnlyOnce(t *testing.T) {
 	mockClock := clock.NewMock()
 
 	params := CollectorParams{
+		DataType:      CaptureTypeTabular,
 		ComponentName: "testComponent",
 		Interval:      interval,
 		MethodParams:  map[string]*anypb.Any{"name": fakeVal},
@@ -327,10 +348,10 @@ func validateReadings(t *testing.T, act []*v1.SensorData, n int) {
 	}
 }
 
-//nolint
 func getAllFiles(dir string) []os.FileInfo {
 	var files []os.FileInfo
 	_ = filepath.Walk(dir, func(path string, info os.FileInfo, err error) error {
+		//nolint:nilerr
 		if err != nil {
 			return nil
 		}