Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Threlte for Svelte 5 upgrade #600

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

micheal-parks
Copy link
Member

@micheal-parks micheal-parks commented Nov 12, 2024

Overview

This PR gets rid of Threlte imports that have been removed in v8 - the Svelte 5 compatible version.

This is part of a larger slow effort to move us to be ready to upgrade to Svelte 5.

There's actually only one removed import here, and it has to do with event dispatching. Callback props ftw!

Copy link
Contributor

@ethanlookpotts ethanlookpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love callback props! Thanks for keeping an eye on this! Two thoughts:

  1. Do you mind following this PR up with a bump in App just so we don't forget about the changes here and have version drift?
  2. Can we think of ways to increase test coverage over these components? There's a lot of critical navigation map infra that is going untested at the moment.

@micheal-parks
Copy link
Member Author

@ethanlookpotts Thank you!

  1. For sure, modeled this change so that we could bump immediately 🚀
  2. I've been talking to Cousins about this problem lately. The lack of coverage was the result in these components involving maplibre and threlte. @threlte/test doesn't have a canvas + webgl mock, making testing maplibre impossible with the tool, but I think we might have found a potential solution: Vite's new browser mode, which will have a webgl context. I've made some plans in the near future to experiment with adding some browser mode tests specifically here since like you mentioned these components are growing in value and need tests.

Copy link
Member

@zaporter-work zaporter-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- don't have much content on the threlte bump though.

@micheal-parks micheal-parks merged commit 721c886 into viamrobotics:main Nov 13, 2024
4 checks passed
@micheal-parks micheal-parks deleted the threlte-prep branch November 13, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants