-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Threlte for Svelte 5 upgrade #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love callback props! Thanks for keeping an eye on this! Two thoughts:
- Do you mind following this PR up with a bump in App just so we don't forget about the changes here and have version drift?
- Can we think of ways to increase test coverage over these components? There's a lot of critical navigation map infra that is going untested at the moment.
@ethanlookpotts Thank you!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- don't have much content on the threlte bump though.
Overview
This PR gets rid of Threlte imports that have been removed in v8 - the Svelte 5 compatible version.
This is part of a larger slow effort to move us to be ready to upgrade to Svelte 5.
There's actually only one removed import here, and it has to do with event dispatching. Callback props ftw!