ESLint: update peers in advance of v9 upgrade

[mcous]

Overview

We're running a few versions behind on our ESLint plugins, and 1 major version behind on ESLint itself.

• TS-related ESLint deps are blocking a TS update
• ESLint v8 is now officially deprecated by the ESLint team

We've got one remaining ESLint plugin to go before we're unblocked on the v9 update, so in advance of that, this PR gets every plugin onto their latest version to:

• Ease the v9 update, since most of these configs/plugins now support both v8 and v9
• Unblock a TS update in app

Change log

• Breaking Drop eslint-plugin-sonarjs
  • Did an unofficial poll in Slack a while back; I don't think we feel strongly about this plugin
  • It was blocking our update to @typescript-eslint v8 and eslint v9
  • It pulls in a bunch of unnecessary dependencies (e.g. eslint-plugin-react)
  • They don't have a public issue tracker and are generally not easy to work with, because they're trying to sell you on using the SonarJS service
• Grab a few rules that needed to be migrated overs
  • Disable rules enforcing destructuring format - these have proved to be annoying and result in hard-to-read code
  • Add lint to enforce import type { ... } where able
  • Fix template string lint to prevent accidentally printing the undefined
• Update ESLint peer dep ranges
• Update pinned pnpm version

[mcous]

Wanted to call this one out because it finally adds lint enforcement for:

// no
import { type Thing } from './place'
// yes
import type { Thing } from './place'

Which could be really helpful for circular dependency issues, depending on how rollup and/or esbuild do or don't strip imports

[micheal-parks]

Yes! Nice, glad this is linted now

[mcous]

Confirmed with Devin via Slack, gonna merge this one in to unblock continuing work